Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-24426] Android: Remove 'Alert' title from alert() #8846

Merged
merged 7 commits into from
Nov 27, 2017
Merged

[TIMOB-24426] Android: Remove 'Alert' title from alert() #8846

merged 7 commits into from
Nov 27, 2017

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Feb 22, 2017

@hansemannn hansemannn changed the title [AC-4817] Android: Remove 'Alert' title from alert() [TIMOB-24426] Android: Remove 'Alert' title from alert() Feb 24, 2017
@build
Copy link
Contributor

build commented Nov 3, 2017 •
edited

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
🚫

Tests have failed, see below for more information.
Messages
📖

🎉 Another contribution from our awesome community member, m1ga! Thanks again for helping us make Titanium SDK better. 👍
📖

💾 Here's the generated SDK zipfile.

Tests:

Classname Name Time Error
ios.Titanium.Network.Socket.TCP #connect() and receive data 5.09 file:///Users/build/Library/Developer/CoreSim

Generated by 🚫 dangerJS

@sgtcoolguy sgtcoolguy added this to the 7.1.0 milestone Nov 27, 2017
@sgtcoolguy sgtcoolguy added the ios label Nov 27, 2017
@sgtcoolguy sgtcoolguy self-assigned this Nov 27, 2017
@sgtcoolguy sgtcoolguy requested review from sgtcoolguy and removed request for garymathews November 27, 2017 18:42
@sgtcoolguy sgtcoolguy merged commit ebcaee3 into tidev:master Nov 27, 2017
@m1ga m1ga deleted the alert branch December 10, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees

@sgtcoolguy sgtcoolguy

Labels
android community 🔥 improvement ios
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@m1ga @build @sgtcoolguy @hansemannn